Chasing the Bugs!Posted on January 15, 2017
A lot of bugs have been squashed – but a lot of them have also been discovered…As mentioned last week, my primary aim is to get the system into a relatively bug-free state prior to adding new functionality. The graph above shows that I fixed quite a few this week, but I have also discovered quite a few too.
Although no closer to starting the column movement code, it is still a good position to be in as I now have a system that has 13 fewer issues in it. Alas, not all coding can be glorious and exciting new functionality!
Most of the work that took place this week occurred in the Armies module – the module that models all aspects of units and armies.
The first ‘issue’ was this one…
Issues orders to cavalry units…
Starting positions for the default cavalry units.Runs a 30 second turn and ends up with:
Errr…. What happened?The units didn’t exactly move very far…
These kind of bugs can be quite hard to find as the system keeps track of a multitude of variables for each unit. These variables can be hard to follow because the system runs multi-threaded.
Luckily, one of the pieces of work that I also did this week was to update the formation classification system to bring it up to date with the current modelling.
The classification system puts a symbol on a unit to tell the user whether it is Open Order (OO), Order (O), Close Order (CO) or Dense (D). The idea being that a player can instantly see how tightly packed a formation is – something that would be impossible to tell just by looking at the unit.
This subsystem was very old and didn’t reflect what was really happening. However, this was rectified, resulting in units being properly classified.
That said, I should probably point out that the game does not use this classification – it knows a unit’s precise measurements – the classification is solely a player aid only.
In my case, the classification helped track the issue above…
Ah… That would be it…When I zoomed in onto one of the cavalry units I saw that its density classification is ‘D’ or dense. That would explain why the units were having problems moving!
These units were created very quickly using default unit sizes, formations, frontages and densities. However, it would appear that these defaults don’t give you units that function well…
This defined my next task:
‘Update the defaults to generate units that function correctly when created!’
The result:
Starting positions with the new unit default sizes...Note the defaults have made the cavalry units a lot larger. Ok, lets run a turn and see how they perform…
That’s more like it – there was actually some movement!Bingo! All sorted….
Well almost….
The problem with the new defaults is that they highlight just how large the unit size variations can be. Alas, the Army Editor’s display window just couldn’t cope with some of these new sizes:
Oh – that doesn’t look right…Damn! I’m missing a fair bit of the unit. Creating a Chariot unit results in the whole screen being filled by part of that unit! Not good at all.
Conversely, small units like a Roman Maniple became very small and difficult to see.
To fix this, I altered the code in that pane to automatically zoom the camera to properly show off the chosen unit. This code was not trivial as one has to work out apparent sizes in metres based on the camera distance.
Nevertheless it got fixed:
Much Better!Perfectly zoomed!
Even small units are now zoomed correctly:
Even the tiny Maniple is now scaled appropriately!The eagle eyed amongst you will have noticed that the window also gets a new scale in the bottom left so that users can more easily determine the size of a unit.
Fixes to tooling might seem a waste of time, but these tools are used to create the game assets – they will also be distributed with the game to allow players to create their own maps, units, armies and scenarios too….
Going back to the loaded scenario, I noticed another potential issue:
Classification ‘O’ (Order) – Really? A Macedonian Phalangite? You are kidding?I thought ‘Oh No – the new classification system is broken already.’
Based on general wargamer bias and expectation, the Macedonian unit seemed to have an incorrect classification. Such a unit would at least be close order, if not dense!
However, after doing my research, I have discovered that this is in fact correct!
This is the default phalanx formation at 16 deep. The Macedonians didn’t even give it a name, because it was the ‘standard’ formation. However, some texts do refer to this formation as the Open formation!!! Woot! My system seems to have classified correctly!
If the above unit closes down to the 8 deep Pyknosis formation, as used prior to contact, the result is:
Pyknosis – classified as CO (Close Order) – Breaths a sigh of relief!CO!!! Perfect. Closing the formation down further to the 4 deep Synaspismos results in the system correctly classifying it as ‘D’ or dense.
Of course, when I did my first formation change, I noticed a bug where the visible model’s density classification was not being updated. But this was a trivial issue and easily fixed.
So what’s planned for next week?
Well, I now have two big issues I need to look at.
First up is the text on the units. These don’t seem to be created at the correct sizes anymore. The font is either too small on large units, or too large on small units. I suspect that this is due to Windows 10 DPI scaling – most machines seem to be set to around 150%.
Fixing this issue will be difficult, but it is one that will need addressing as the unit text is the system’s primary way of communicating unit information to the player.
The next issue is related to the potential ‘bug’ described at the top of this blog entry….
It seems that Ancient Armies has got to the point where there are many subsystems acting on each unit. These affect a multitude of hidden variables with results that sometimes seem counter-intuitive – like in our example above.
However, debugging these issues is difficult as one really needs to see these variables changing over time to fully appreciate what is happening and why. This is made all the harder by the game being multi-threaded.
Luckily, Ancient Armies already records everything, all thanks to Chronos that was fitted last year. So the information is available, I just need a way to display it.
So one of my next tasks will be to create a debug monitor application. One that I can run on a separate computer that will monitor the game running and display graphs and debug information for each unit.
This will be a non-trivial task that will take a fair bit of time to complete. At first, this might seem to be a frivolous thing to do, but it will save a lot of time in the long run. This is because with such a tool I will be able to see what’s happening inside the units in realtime so that I can assess whether what I’m seeing is intended behaviour or not.
Going forward, the system will only get more complex, so a monitoring tool like this one will become critical to speeding up development.
So that’s my tasks fixed for the next few weeks! Sorry column movement, I will visit you eventually! Honest!
Laters
RobP
Original post: Click Here